Browse filter results on page #4005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenejac
requested changes
Sep 27, 2024
There was a problem hiding this comment.
General comment
This might be a nice feature to have in VIVO.
Testing
I found a couple of issues:
- Person filter is not working in my case. Persons are listed on left side, there are numbers in the brackets, but when I click on a person, the list of articles is not displayed (for other filter pages (Organization, Type, Year, Category, it is working)
- Serbian alphabetical index is not working properly for two letters codes (Dž, Lj, Nj), this should list articles starting with Dž, Lj, or Nj, but it is listing at the moment articles starting with D or Ž (union of lists under D index and Ž index).
- For some languages alphabetical index is not defined properly (this can be fixed at the end of the review process)
Code reviewing
Didn't review code yet.
|
Thank you for testing.
I think Person filter is not configured to include any person related publications in default VIVO configuration I suppose it should be extended, but I think it is not linked to this PR.
Thanks. There was an issue with the regular expression I used. It should be fixed now (in Vitro PR). Please try again.
Sure, I think we will have to ask native speakers to check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vitro PR
What does this pull request do?
Adds an option to select search filter to display filtered results on custom page.
What's new?
Please take a look at Vitro PR first.
Updated PageManagement entry form files to align with Vitro PR.
How should this be tested?
A description of what steps someone could take to:
Additional Notes:
This change require documentation to be updated.
Interested parties
@hauschke @VIVO-project/vivo-committers
Reviewers' expertise
Candidates for reviewing this PR should have some of the following expertises:
Reviewers' report template
Please update the following template which should be used by reviewers.
General comment
A reviewer should provide here comments and suggestions for requested changes if any.
Testing
A reviewer should briefly describe here how it was tested
Code reviewing
A reviewer should briefly describe here which part was code reviewed